SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 3.1.1
Threshold is low
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 78 |
23 |
0 |
1 |
de.tu_clausthal.in.bachelorproject2018.poker.controller.CGameActionController
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in de.tu_clausthal.in.bachelorproject2018.poker.controller.CGameActionController.createUser(CSessionRegistration, SimpMessageHeaderAccessor) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
56 |
Medium |
de.tu_clausthal.in.bachelorproject2018.poker.controller.CGameActionController$CMessage
| Bug |
Category |
Details |
Line |
Priority |
| CGameActionController$CMessage.m_value not initialized in constructor and dereferenced in de.tu_clausthal.in.bachelorproject2018.poker.controller.CGameActionController$CMessage.get() |
STYLE |
UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR |
103 |
Low |
de.tu_clausthal.in.bachelorproject2018.poker.game.action.CRaise
| Bug |
Category |
Details |
Line |
Priority |
| Unused field: de.tu_clausthal.in.bachelorproject2018.poker.game.action.CRaise.player |
PERFORMANCE |
UUF_UNUSED_FIELD |
|
Medium |
| Unused field: de.tu_clausthal.in.bachelorproject2018.poker.game.action.CRaise.table |
PERFORMANCE |
UUF_UNUSED_FIELD |
|
Medium |
de.tu_clausthal.in.bachelorproject2018.poker.game.round.CFlop
| Bug |
Category |
Details |
Line |
Priority |
| Null passed for non-null parameter of new de.tu_clausthal.in.bachelorproject2018.poker.network.gamestate.messages.CCardMessage(Card, String, String, ITable, IPlayer) in de.tu_clausthal.in.bachelorproject2018.poker.game.round.CFlop.apply(Queue) |
CORRECTNESS |
NP_NONNULL_PARAM_VIOLATION |
39 |
High |
de.tu_clausthal.in.bachelorproject2018.poker.game.round.CPreFlop
| Bug |
Category |
Details |
Line |
Priority |
| Null passed for non-null parameter of new de.tu_clausthal.in.bachelorproject2018.poker.network.gamestate.messages.CCardMessage(Card, String, String, ITable, IPlayer) in de.tu_clausthal.in.bachelorproject2018.poker.game.round.CPreFlop.apply(Queue) |
CORRECTNESS |
NP_NONNULL_PARAM_VIOLATION |
46 |
High |
de.tu_clausthal.in.bachelorproject2018.poker.game.round.CRiver
| Bug |
Category |
Details |
Line |
Priority |
| Null passed for non-null parameter of new de.tu_clausthal.in.bachelorproject2018.poker.network.gamestate.messages.CCardMessage(Card, String, String, ITable, IPlayer) in de.tu_clausthal.in.bachelorproject2018.poker.game.round.CRiver.apply(Queue) |
CORRECTNESS |
NP_NONNULL_PARAM_VIOLATION |
39 |
High |
de.tu_clausthal.in.bachelorproject2018.poker.game.round.CTurn
| Bug |
Category |
Details |
Line |
Priority |
| Null passed for non-null parameter of new de.tu_clausthal.in.bachelorproject2018.poker.network.gamestate.messages.CCardMessage(Card, String, String, ITable, IPlayer) in de.tu_clausthal.in.bachelorproject2018.poker.game.round.CTurn.apply(Queue) |
CORRECTNESS |
NP_NONNULL_PARAM_VIOLATION |
36 |
High |
de.tu_clausthal.in.bachelorproject2018.poker.game.round.CWinEvaluation
| Bug |
Category |
Details |
Line |
Priority |
| de.tu_clausthal.in.bachelorproject2018.poker.game.round.CWinEvaluation.apply(Queue) concatenates strings using + in a loop |
PERFORMANCE |
SBSC_USE_STRINGBUFFER_CONCATENATION |
58 |
Medium |
de.tu_clausthal.in.bachelorproject2018.poker.game.round.ERound
| Bug |
Category |
Details |
Line |
Priority |
| de.tu_clausthal.in.bachelorproject2018.poker.game.round.ERound.next() can't throw NoSuchElementException |
BAD_PRACTICE |
IT_NO_SUCH_ELEMENT |
82 |
Low |
de.tu_clausthal.in.bachelorproject2018.poker.game.table.CTable
| Bug |
Category |
Details |
Line |
Priority |
| Unused field: de.tu_clausthal.in.bachelorproject2018.poker.game.table.CTable.m_eventPublisher |
PERFORMANCE |
UUF_UNUSED_FIELD |
|
Medium |
de.tu_clausthal.in.bachelorproject2018.poker.game.wincheck.CFlush
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in de.tu_clausthal.in.bachelorproject2018.poker.game.wincheck.CFlush.apply(HandStatistic) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
43 |
Medium |
de.tu_clausthal.in.bachelorproject2018.poker.network.gamestate.CGamestateEventPublisher
| Bug |
Category |
Details |
Line |
Priority |
| de.tu_clausthal.in.bachelorproject2018.poker.network.gamestate.CGamestateEventPublisher.publishEvent() makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
28 |
Medium |
de.tu_clausthal.in.bachelorproject2018.poker.network.gamestate.EGamestateManagement
| Bug |
Category |
Details |
Line |
Priority |
| de.tu_clausthal.in.bachelorproject2018.poker.game.table.ITable is incompatible with expected argument type String in de.tu_clausthal.in.bachelorproject2018.poker.network.gamestate.EGamestateManagement.add(IGamestate) |
CORRECTNESS |
GC_UNRELATED_TYPES |
29 |
High |
| Useless control flow in de.tu_clausthal.in.bachelorproject2018.poker.network.gamestate.EGamestateManagement.add(IGamestate) |
STYLE |
UCF_USELESS_CONTROL_FLOW |
29 |
Low |
de.tu_clausthal.in.bachelorproject2018.poker.network.objects.CCardJson
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: de.tu_clausthal.in.bachelorproject2018.poker.network.objects.CCardJson.m_card |
PERFORMANCE |
URF_UNREAD_FIELD |
16 |
Low |
| Unread field: de.tu_clausthal.in.bachelorproject2018.poker.network.objects.CCardJson.m_destination |
PERFORMANCE |
URF_UNREAD_FIELD |
17 |
Low |
| Unread field: de.tu_clausthal.in.bachelorproject2018.poker.network.objects.CCardJson.m_type |
PERFORMANCE |
URF_UNREAD_FIELD |
18 |
Low |
de.tu_clausthal.in.bachelorproject2018.poker.network.objects.CChipJson
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: de.tu_clausthal.in.bachelorproject2018.poker.network.objects.CChipJson.m_amount |
PERFORMANCE |
URF_UNREAD_FIELD |
11 |
Low |
de.tu_clausthal.in.bachelorproject2018.poker.network.objects.CErrorJson
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: de.tu_clausthal.in.bachelorproject2018.poker.network.objects.CErrorJson.m_error |
PERFORMANCE |
URF_UNREAD_FIELD |
11 |
Low |
de.tu_clausthal.in.bachelorproject2018.poker.network.objects.CMessageEvent
| Bug |
Category |
Details |
Line |
Priority |
| Class de.tu_clausthal.in.bachelorproject2018.poker.network.objects.CMessageEvent defines non-transient non-serializable instance field m_table |
BAD_PRACTICE |
SE_BAD_FIELD |
|
Medium |
de.tu_clausthal.in.bachelorproject2018.poker.network.objects.CNotifyJson
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: de.tu_clausthal.in.bachelorproject2018.poker.network.objects.CNotifyJson.m_text |
PERFORMANCE |
URF_UNREAD_FIELD |
12 |
Low |
de.tu_clausthal.in.bachelorproject2018.poker.network.objects.CNotifyPlayerEvent
| Bug |
Category |
Details |
Line |
Priority |
| Class de.tu_clausthal.in.bachelorproject2018.poker.network.objects.CNotifyPlayerEvent defines non-transient non-serializable instance field m_player |
BAD_PRACTICE |
SE_BAD_FIELD |
|
Medium |
